Keep position on rotation #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’ve added a flag (keepPositionOnRotation) to BarLineChartBase indicating whether the chart should stay at its current position or not.
|
+1 to this, does it work for linechart too? |
|
@silva96 Works for all Charts that inherit from BarLineChartBase. Basically all charts that move. |
|
Done beautifully on the first take, conforming to the style of the framework on both Android and iOS. Thank you! |
|
Currently only on my mobile, I will review it later. |
PhilJay
added a commit
that referenced
this pull request
Mar 10, 2016
regas99
pushed a commit
to regas99/MPAndroidChart
that referenced
this pull request
Apr 1, 2019
Keep position on rotation
regas99
pushed a commit
to regas99/MPAndroidChart
that referenced
this pull request
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve added a flag (keepPositionOnRotation) to BarLineChartBase
indicating whether the chart
should stay at its current position or not.
This is the same feature as described in the PR on ios-charts
In the examples this feature doesn't work properly, because the Activities get reloaded on every rotation. This can be turned of be adding
<activity android:name="BarChartActivity" android:configChanges="keyboardHidden|orientation|screenSize"></activity>in the AppManifest.