Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep position on rotation #1565

Merged
merged 1 commit into from
Mar 10, 2016
Merged

Keep position on rotation #1565

merged 1 commit into from
Mar 10, 2016

Conversation

leoMehlig
Copy link
Contributor

I’ve added a flag (keepPositionOnRotation) to BarLineChartBase
indicating whether the chart
should stay at its current position or not.

This is the same feature as described in the PR on ios-charts

In the examples this feature doesn't work properly, because the Activities get reloaded on every rotation. This can be turned of be adding <activity android:name="BarChartActivity" android:configChanges="keyboardHidden|orientation|screenSize"></activity> in the AppManifest.

I’ve added a flag (keepPositionOnRotation) to BarLineChartBase
indicating whether the chart
should stay at its current position or not.
@silva96
Copy link

silva96 commented Mar 10, 2016

+1 to this, does it work for linechart too?

@leoMehlig
Copy link
Contributor Author

@silva96 Works for all Charts that inherit from BarLineChartBase. Basically all charts that move.

@danielgindi
Copy link
Collaborator

Done beautifully on the first take, conforming to the style of the framework on both Android and iOS. Thank you!

@PhilJay
Copy link
Owner

PhilJay commented Mar 10, 2016

Currently only on my mobile, I will review it later.
But if Daniel says it's beautiful, I guess it really is :-)

PhilJay added a commit that referenced this pull request Mar 10, 2016
@PhilJay PhilJay merged commit 083e91a into PhilJay:master Mar 10, 2016
PhilJay added a commit that referenced this pull request Mar 10, 2016
regas99 pushed a commit to regas99/MPAndroidChart that referenced this pull request Apr 1, 2019
regas99 pushed a commit to regas99/MPAndroidChart that referenced this pull request Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants